sunchao commented on PR #7361:
URL: 
https://github.com/apache/datafusion-comet/pull/7361#issuecomment-7018779362

   Reviewed `13fd925bb51a73f88ea3d301fe390dd44241fb89` across five independent 
scopes. No new actionable findings beyond the existing coverage, benchmark and 
defensive-fetch discussion. Posting as a conversation comment because this PR 
is authored by the reviewing account.
   
   Traced the Scala/native admission checks, computed-key projection, reducer, 
replacement sort and join. The unfiltered left-semi path uses the same 
projected key throughout, preserves nullable-key semantics and duplicate left 
rows, and does not need the discarded right columns. Admission checks precede 
the rewrite; current callers exclude limited sorts. The existing default 
remains false. The tests assert native plan structure, real row reduction and 
NULL behavior, with the relevant suites registered in CI. Projection also runs 
for batches that bypass reduction, so the existing request to isolate 
projection effects in the benchmark remains relevant; reported timings are not 
independent measurements from this review.
   
   Validation: the exact head has 18 successful and 19 skipped upstream checks, 
including the Spark 4.1 build and all nine Spark SQL shards. The [matching fork 
run](https://github.com/sunchao/arrow-datafusion-comet/actions/runs/41223075305)
 has 23 successful and 18 skipped jobs, including Rust tests, the native build 
and Spark 4.1 Comet suites. Other Spark SQL profiles were skipped. No local 
tests, test binaries, benchmarks or executable reproduction probes were run. 
This is a comment-only review, not an approval.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to