comphead commented on code in PR #1398:
URL: https://github.com/apache/datafusion-comet/pull/1398#discussion_r1956404175
##########
docs/source/user-guide/configs.md:
##########
@@ -17,6 +17,12 @@ specific language governing permissions and limitations
under the License.
-->
+<!--
+TO MODIFY THIS CONTENT MAKE SURE THAT YOU MAKE YOUR CHANGES TO THE TEMPLATE
FILE
Review Comment:
👍
##########
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##########
@@ -1352,15 +1352,11 @@ object CometSparkSessionExtensions extends Logging {
org.apache.spark.SPARK_VERSION >= "4.0"
}
- def isComplexTypeReaderEnabled(conf: SQLConf): Boolean = {
+ def usingParquetExec(conf: SQLConf): Boolean = {
Review Comment:
`usingParquetExec` isn't it too generic? `usingNativeScan` or
`usingNativeDataFusionScan`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
