jonahgao commented on code in PR #15099:
URL: https://github.com/apache/datafusion/pull/15099#discussion_r1986094870
##########
datafusion/optimizer/src/optimizer.rs:
##########
@@ -240,7 +239,6 @@ impl Optimizer {
// Filters can't be pushed down past Limits, we should do
PushDownFilter after PushDownLimit
Arc::new(PushDownLimit::new()),
Arc::new(PushDownFilter::new()),
- Arc::new(SingleDistinctToGroupBy::new()),
Review Comment:
Queries like `avg(distinct a)` rely on this rule, and without it, they
cannot be executed anymore.
The following query is available on the main branch, but not on this PR
branch.
```sh
DataFusion CLI v46.0.0
> select avg(distinct a) from values(1) t(a);
Execution error: avg(DISTINCT) aggregations are not available
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
