alamb commented on code in PR #15099:
URL: https://github.com/apache/datafusion/pull/15099#discussion_r1988994922
##########
datafusion/optimizer/src/optimizer.rs:
##########
@@ -240,7 +239,6 @@ impl Optimizer {
// Filters can't be pushed down past Limits, we should do
PushDownFilter after PushDownLimit
Arc::new(PushDownLimit::new()),
Arc::new(PushDownFilter::new()),
- Arc::new(SingleDistinctToGroupBy::new()),
Review Comment:
The alternative would be to directly implement distinct support in the avg
accumulator
The lack of avg support means we can't run multiple distinct avg aggregates
```sql
> select avg(distinct a), avg(distinct b) from values(1, 2) t(a, b);
```
This is tracked by
- v
##########
datafusion/optimizer/src/optimizer.rs:
##########
@@ -240,7 +239,6 @@ impl Optimizer {
// Filters can't be pushed down past Limits, we should do
PushDownFilter after PushDownLimit
Arc::new(PushDownLimit::new()),
Arc::new(PushDownFilter::new()),
- Arc::new(SingleDistinctToGroupBy::new()),
Review Comment:
The alternative would be to directly implement distinct support in the avg
accumulator
The lack of avg support means we can't run multiple distinct avg aggregates
```sql
> select avg(distinct a), avg(distinct b) from values(1, 2) t(a, b);
```
This is tracked by
- https://github.com/apache/datafusion/issues/2408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
