wForget commented on code in PR #1556:
URL: https://github.com/apache/datafusion-comet/pull/1556#discussion_r2011174417
##########
spark/src/test/scala/org/apache/spark/sql/benchmark/CometReadBenchmark.scala:
##########
@@ -71,6 +73,7 @@ object CometReadBenchmark extends CometBenchmarkBase {
sqlBenchmark.addCase("SQL Parquet - Comet Native DataFusion") { _ =>
withSQLConf(
CometConf.COMET_ENABLED.key -> "true",
+ CometConf.COMET_EXEC_ENABLED.key -> "true",
Review Comment:
> I am not sure if we should enable `COMET_EXEC_ENABLED` as it will mix the
scan benchmark and exec benchmark
It seems difficult to benchmark only scan anyway. If we disable exec
conversion, it may introduce the performance loss of ColumnarToRow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
