wForget commented on code in PR #1556:
URL: https://github.com/apache/datafusion-comet/pull/1556#discussion_r2006770729
##########
spark/src/test/scala/org/apache/spark/sql/benchmark/CometReadBenchmark.scala:
##########
@@ -63,6 +65,7 @@ object CometReadBenchmark extends CometBenchmarkBase {
sqlBenchmark.addCase("SQL Parquet - Comet") { _ =>
withSQLConf(
CometConf.COMET_ENABLED.key -> "true",
+ CometConf.COMET_EXEC_ENABLED.key -> "true",
Review Comment:
CometBenchmarkBase sets COMET_EXEC_ENABLED to false by default, while native
scan requires COMET_EXEC_ENABLED=true
https://github.com/apache/datafusion-comet/blob/main/spark/src/test/scala/org/apache/spark/sql/benchmark/CometBenchmarkBase.scala#L53-L54
https://github.com/apache/datafusion-comet/blob/52241085181449e4bdb3345b035bf28fef5b6c34/spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala#L213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
