Omega359 commented on code in PR #15361:
URL: https://github.com/apache/datafusion/pull/15361#discussion_r2019547635
##########
datafusion/functions/src/datetime/to_char.rs:
##########
@@ -277,7 +282,25 @@ fn _to_char_array(args: &[ColumnarValue]) ->
Result<ColumnarValue> {
let result = formatter.value(idx).try_to_string();
match result {
Ok(value) => results.push(Some(value)),
- Err(e) => return exec_err!("{}", e),
+ Err(e) => {
+ if data_type == &Date32 {
Review Comment:
> > Yeah, this is a limitation of arrow-rs currently. I never got around to
pushing a PR to arrow-rs to change that.
>
> I'd be happy to work on this next, if you'd like.
It would clean things up but I'm not sure if it would be a measurable
performance improvement or not. Leaning to it not being all that noticeable but
I'm often wrong :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
