alamb commented on code in PR #15361:
URL: https://github.com/apache/datafusion/pull/15361#discussion_r2020139946
##########
datafusion/functions/src/datetime/to_char.rs:
##########
@@ -220,6 +221,13 @@ fn _to_char_scalar(
}
}
+ // eagerly cast Date32 values to Date64 to support date formatting with
time-related specifiers
+ // without error.
+ if data_type == &Date32 {
Review Comment:
as @Omega359 says, this will now penalize performance for all existing
Date32 columns
Is there any way we can check if the format string contains any time related
specifiers before doing this conversion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
