andygrove commented on code in PR #1768:
URL: https://github.com/apache/datafusion-comet/pull/1768#discussion_r2114220564
##########
spark/src/test/scala/org/apache/comet/CometStringExpressionSuite.scala:
##########
@@ -20,87 +20,68 @@
package org.apache.comet
import org.apache.spark.sql.CometTestBase
+import org.apache.spark.sql.internal.SQLConf
class CometStringExpressionSuite extends CometTestBase {
test("Various String scalar functions") {
- Seq(false, true).foreach { dictionary =>
- withSQLConf("parquet.enable.dictionary" -> dictionary.toString) {
Review Comment:
This is an unrelated change but none of the tests in this suite create data
that would use dictionary encoding (they just insert a few rows and there are
no duplicates) so it is pointless running all of these tests with and without
dictionary encoding enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
