Dandandan commented on code in PR #16380:
URL: https://github.com/apache/datafusion/pull/16380#discussion_r2142058321
##########
datafusion/physical-plan/src/joins/hash_join.rs:
##########
@@ -95,9 +96,11 @@ struct JoinLeftData {
/// The hash table with indices into `batch`
hash_map: JoinHashMap,
/// The input rows for the build side
- batch: RecordBatch,
- /// The build side on expressions values
- values: Vec<ArrayRef>,
+ batch: Vec<RecordBatch>,
Review Comment:
Yeah this should be it, I think the tricky part of it might be to get it to
equal performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
