zhuqi-lucas commented on code in PR #16369:
URL: https://github.com/apache/datafusion/pull/16369#discussion_r2142643694
##########
datafusion/physical-optimizer/src/insert_yield_exec.rs:
##########
@@ -92,3 +96,23 @@ impl PhysicalOptimizerRule for InsertYieldExec {
true
}
}
+
+#[cfg(test)]
+mod tests {
+ use super::*;
+ use datafusion_common::assert_contains;
+ use datafusion_common::config::ConfigOptions;
+ use datafusion_physical_plan::{displayable, test::scan_partitioned};
+
+ #[tokio::test]
+ async fn test_yield_stream_exec_for_custom_exec() {
+ let test_custom_exec = scan_partitioned(1);
+ let config = ConfigOptions::new();
+ let optimized = InsertYieldExec::new()
+ .optimize(test_custom_exec, &config)
+ .unwrap();
+
+ let display = displayable(optimized.as_ref()).indent(true).to_string();
Review Comment:
Thank you @alamb for good suggestion, addressed in latest PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
