andygrove commented on code in PR #1830:
URL: https://github.com/apache/datafusion-comet/pull/1830#discussion_r2175499403


##########
.github/actions/java-test/action.yaml:
##########
@@ -68,7 +68,7 @@ runs:
       env:
         COMET_PARQUET_SCAN_IMPL: ${{ inputs.scan_impl }}
       run: |
-        MAVEN_OPTS="-XX:+UnlockDiagnosticVMOptions -XX:+ShowMessageBoxOnError 
-XX:+HeapDumpOnOutOfMemoryError -XX:ErrorFile=./hs_err_pid%p.log" 
SPARK_HOME=`pwd` ./mvnw -B clean install ${{ inputs.maven_opts }}
+        MAVEN_OPTS="-Xmx4G -Xms2G -XX:+UnlockDiagnosticVMOptions 
-XX:+ShowMessageBoxOnError -XX:+HeapDumpOnOutOfMemoryError 
-XX:ErrorFile=./hs_err_pid%p.log" SPARK_HOME=`pwd` ./mvnw -B clean install ${{ 
inputs.maven_opts }}

Review Comment:
   The Comet test suites fail with OOM when running on macOS. I tried this 
change to specify more memory, but it did not make any difference. The macOS 
workflow is commented out in this PR, and I filed a follow up issue 
https://github.com/apache/datafusion-comet/issues/1949



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to