andygrove commented on code in PR #1830: URL: https://github.com/apache/datafusion-comet/pull/1830#discussion_r2175531317
########## dev/diffs/4.0.0.diff: ########## @@ -67,7 +53,7 @@ index 56aad01023d..ad9d6a973e4 100644 <!-- This spark-tags test-dep is needed even though it isn't used in this module, otherwise testing-cmds that exclude diff --git a/sql/core/src/main/scala/org/apache/spark/sql/classic/SparkSession.scala b/sql/core/src/main/scala/org/apache/spark/sql/classic/SparkSession.scala -index 0015d7ff99e..9278e2fb5f3 100644 +index 0015d7ff99..c9dd85e72c 100644 Review Comment: This commit introduces a lot of changes because the hash is 10 digits instead of 11. This can be avoided by executing `git config core.abbrev 11;` before making the diff (taken from https://datafusion.apache.org/comet/contributor-guide/spark-sql-tests.html#generating-the-diff-file). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org