adriangb commented on code in PR #16791:
URL: https://github.com/apache/datafusion/pull/16791#discussion_r2210616673
##########
datafusion/datasource-parquet/src/row_filter.rs:
##########
@@ -140,6 +143,8 @@ impl ArrowPredicate for DatafusionArrowPredicate {
}
fn evaluate(&mut self, batch: RecordBatch) -> ArrowResult<BooleanArray> {
+ let batch = self.schema_mapper.map_batch(batch)?;
Review Comment:
This code basically becomes a no-op if a predicate rewriter is used. But
instead of making it Option<SchemaAdapter> or something like that I think it's
easier to minimize the version on version diff and code paths to leave it be.
It's a no-op because when the schema mapping is calculated it will be from
the physical file schema to the physical file schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
