adriangb commented on code in PR #16791:
URL: https://github.com/apache/datafusion/pull/16791#discussion_r2211280296
##########
datafusion/datasource-parquet/src/source.rs:
##########
@@ -468,10 +468,50 @@ impl FileSource for ParquetSource {
let projection = base_config
.file_column_projection_indices()
.unwrap_or_else(||
(0..base_config.file_schema.fields().len()).collect());
- let schema_adapter_factory = self
- .schema_adapter_factory
- .clone()
- .unwrap_or_else(|| Arc::new(DefaultSchemaAdapterFactory));
+
+ if self.schema_adapter_factory.is_some() {
+ log::warn!("The SchemaAdapter API will be removed from
ParquetSource in a future release. \
+ Use PhysicalExprAdapterFactory API instead. \
+ See https://github.com/apache/datafusion/issues/16800 for
discussion and
https://datafusion.apache.org/library-user-guide/upgrading.html#datafusion-49-0-0
for upgrade instructions.");
+ }
+
+ let (expr_adapter_factory, schema_adapter_factory) = match (
Review Comment:
I'm a bit torn: we don't yet have an alternative for projections. We kind of
want to mark it as deprecated for predicates but not for projections, which is
weird. It may be in a bit of a limbo state for a release or two.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
