kosiew opened a new pull request, #16835: URL: https://github.com/apache/datafusion/pull/16835
## Which issue does this PR close? - Closes #16801 ## Rationale for this change - Provides a unified and maintainable test suite for schema adapter functionality by consolidating `schema_adapter_integration_tests.rs` into existing `parquet/schema_adapter.rs`. - Implements `as_any` method for `SchemaAdapterFactory` to allow safe downcasting in tests and runtime. - Simplifies testing infrastructure by removing redundant tests and ensuring all adapter types are tested in a single location. ## What changes are included in this PR? - Removed `core/tests/integration_tests/schema_adapter_integration_tests.rs` and migrated its test cases into `core/tests/parquet/schema_adapter.rs`. - Added `as_any` implementation to `SchemaAdapterFactory` and its key implementations (`DefaultSchemaAdapterFactory`, test adapters). - Adjusted adapter test structs in `table.rs` and `mod.rs` with `as_any` implementations. - Refactored existing tests to reuse migrated logic, reducing duplication. ## Are these changes tested? - ✅ Yes. All migrated tests from the deleted integration test file are preserved and validated in the consolidated `schema_adapter.rs` test module. - ✅ Existing unit and integration tests cover the changes, including behavior of `as_any` for adapter factories. ## Are there any user-facing changes? - ✅ No direct user-facing changes. - ✅ No API breaking changes. - 📝 These are internal refactorings and test consolidations aimed at maintainability and test robustness. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
