findepi commented on code in PR #16835:
URL: https://github.com/apache/datafusion/pull/16835#discussion_r2221391075
##########
datafusion/datasource/src/schema_adapter.rs:
##########
@@ -68,6 +68,8 @@ pub trait SchemaAdapterFactory: Debug + Send + Sync + 'static
{
) -> Box<dyn SchemaAdapter> {
self.create(Arc::clone(&projected_table_schema),
projected_table_schema)
}
+ /// Give us access to Any so callers can downcast.
+ fn as_any(&self) -> &dyn Any;
Review Comment:
If this is needed just to make the tests run, we should avoid adding this,
and find some other way. Existence and structure of our tests should not drive
the shape of public API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
