2010YOUY01 commented on code in PR #16860: URL: https://github.com/apache/datafusion/pull/16860#discussion_r2224349405
########## datafusion/sqllogictest/test_files/joins.slt: ########## @@ -4164,23 +4164,40 @@ AS VALUES (3, 3, true), (3, 3, false); -query IIIIB -SELECT * FROM t0 FULL JOIN t1 ON t0.c1 = t1.c1 LIMIT 2; +query IIIIB rowsort +SELECT * FROM t0 FULL JOIN t1 ON t0.c1 = t1.c1 LIMIT 20; Review Comment: Those 3 tests are supposed to test the `GlobalLimit` operator, instead of TopK, using `order by` might change the test goal. To ensure those tests are deterministic, I set the limit to a number larger than the result set. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
