2010YOUY01 commented on code in PR #16860: URL: https://github.com/apache/datafusion/pull/16860#discussion_r2225641774
########## datafusion/sqllogictest/test_files/joins.slt: ########## @@ -4164,23 +4164,40 @@ AS VALUES (3, 3, true), (3, 3, false); -query IIIIB -SELECT * FROM t0 FULL JOIN t1 ON t0.c1 = t1.c1 LIMIT 2; +query IIIIB rowsort +SELECT * FROM t0 FULL JOIN t1 ON t0.c1 = t1.c1 LIMIT 20; Review Comment: Thanks for the review and suggested changes. That's a great point. Yes, it still changes the test goal, but in my opinion, it's closer to the original test compared to TopK. I think this case could be covered by a sqllogictest property check runner — one that detects queries with a global limit k and asserts that the final result size is <= k. Implementing such a sqllogictest property check extension is on my to-do list, and I hope to find time to work on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org