alamb commented on issue #16903: URL: https://github.com/apache/datafusion/issues/16903#issuecomment-3114729829
I agree we should have a better plan about this Another thing that I would like to consider is allowing users to pick which of the several string representations to generate code for Right now, many of our functions have implementations for `StringArray`, `LargeStringArray`, `StringViewArray`. I suspect some will end up with special implementations for `DictionaryArray` and `REEArray` as well This means that we have 3x the code (and compile time, etc). This leads to large wasm sizes, among other problems - #16554 The same thing applies to group by values, sorting, etc that have specialized versions for String and StringView I wonder if we could/should add config flags for each of the string types 🤔 `features=utf8`, `features=utf8view`, etc However, that sounds like a large testing exercise so maybe it isn't worth the complexity I would love to hear other ideas -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
