alamb commented on issue #16903: URL: https://github.com/apache/datafusion/issues/16903#issuecomment-3145404574
In my opinion, given there are many fast and supported ways to convert between string types (e.g. the arrow `cast` kernels) there is very little value to supporting three different string representations for each function (`Utf8`, `Utf8View` and `LargeUTF8`) I suggest: 1. we treat the function signatures as "internal" to DataFusion and can change (e.g. only support StringView) which will ease maintenance and allow us to focus our efforts on smaller numbers of implementation 2. Have some options that control the output type (like `output_string_type = Utf8`) that can control what types are emitted at the output of a plan. 3. Accept any arbitrary type at the input (potentially coercing to `Utf8View` on input) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
