comphead commented on code in PR #2044:
URL: https://github.com/apache/datafusion-comet/pull/2044#discussion_r2240687173
##########
native/spark-expr/src/conversion_funcs/cast.rs:
##########
@@ -866,6 +867,40 @@ pub fn spark_cast(
}
}
+// copied from datafusion common scalar/mod.rs
+fn dict_from_values<K: ArrowDictionaryKeyType>(
Review Comment:
we can also play with `cast` kernel, looks like such cast might be supported
from `can_cast_types`
```
(_, Dictionary(_, value_type)) => can_cast_types(from_type,
value_type),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
