kosiew commented on issue #16805: URL: https://github.com/apache/datafusion/issues/16805#issuecomment-3134720903
hi @90degs2infty , Thanks for raising this. `DataFusionError::ObjectStore` does indeed wrap `object_store::Error` directly, and the crate exposes several types such as `ObjectStoreUrl`. That means the `object_store` crate is effectively part of DataFusion’s public API, and users need it if they want to pattern‑match on `DataFusionError::ObjectStore` or interact with object stores directly. Since `object_store::Error` implements `std::error::Error`, one can still treat the inner error trait‑object without importing the type, but distinguishing variants or using concrete methods requires the dependency. I think it is not necessary to 'hide' ObjectStore - (thanks to @crepererum's[ thoughts on this](https://github.com/apache/datafusion/pull/16947#issuecomment-3131816841)) What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
