rluvaton commented on issue #16979: URL: https://github.com/apache/datafusion/issues/16979#issuecomment-3135801771
Also, note that my fuzz tests all set `with_sort_spill_reservation_bytes` to `1`: https://github.com/apache/datafusion/blob/0183244a426e5e1fda28c7b6e6961f70f04c0744/datafusion/core/tests/fuzz_cases/spilling_fuzz_in_memory_constrained_env.rs#L59 and I think that we should not reserve memory for merge in: https://github.com/apache/datafusion/blob/0183244a426e5e1fda28c7b6e6961f70f04c0744/datafusion/physical-plan/src/sorts/sort.rs#L569-L570 when called here: https://github.com/apache/datafusion/blob/0183244a426e5e1fda28c7b6e6961f70f04c0744/datafusion/physical-plan/src/sorts/sort.rs#L341-L346 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
