andygrove commented on code in PR #1996:
URL: https://github.com/apache/datafusion-comet/pull/1996#discussion_r2245741631
##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -113,6 +113,16 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
+ test("Integral Division Overflow Handling Matches Spark Behavior") {
+ withTable("t1") {
+ val value = Long.MinValue
+ sql("create table t1(c1 long, c2 short) using parquet")
+ sql(s"insert into t1 values($value, -1)")
+ val res = sql("select c1 div c2 from t1 order by c1")
+ checkSparkAnswer(res)
Review Comment:
Just to follow up on our offline discussion, we do have a cast from long to
decimal but it is disabled by default because it is not compatible with Spark
yet. For now, we can enable the cast in the tests by allowing incompatible
casts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
