andygrove commented on code in PR #1996:
URL: https://github.com/apache/datafusion-comet/pull/1996#discussion_r2245743098
##########
spark/src/main/scala/org/apache/comet/serde/arithmetic.scala:
##########
@@ -212,17 +211,26 @@ object CometIntegralDivide extends CometExpressionSerde
with MathBase {
return None
}
- val dataType = (div.left.dataType, div.right.dataType) match {
+ val left =
+ if (div.left.dataType.isInstanceOf[DecimalType]) div.left
+ else Cast(div.left, DecimalType(19, 0))
Review Comment:
Could you add a comment explaining why 19 is used for precision
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
