Omega359 commented on code in PR #16970: URL: https://github.com/apache/datafusion/pull/16970#discussion_r2245809712
########## datafusion/core/src/execution/session_state.rs: ########## @@ -738,6 +738,17 @@ impl SessionState { self.config.options() } + /// return the configuration options + pub fn config_options_arc(&self) -> Arc<ConfigOptions> { Review Comment: > maybe call it `config_options`? There already is an existing fn with that name that return &ConfigOptions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org