Omega359 commented on PR #16970: URL: https://github.com/apache/datafusion/pull/16970#issuecomment-3145870578
> Good: > > It allows function behavior to be dynamically adapted based on the execution context (e.g., user locale, timezone, session settings, environment specifics). Especially this would be increasingly helpful for downstream projects which have to copy DF function with minor changes and maintain that the code is in sync > > Not so good: DF can end up with bloating code serving the purpose of each downstream project. > > Apparently reviewers need to verify this mechanism is used properly Indeed. Beyond runtime switching of behaviour for custom UDF's I foresee two main use cases for the core udf's - timezone and spark-like 'ansi' mode. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
