nuno-faria commented on code in PR #17031:
URL: https://github.com/apache/datafusion/pull/17031#discussion_r2253601926
##########
datafusion/execution/src/cache/cache_manager.rs:
##########
@@ -39,12 +39,20 @@ pub trait FileMetadata: Any + Send + Sync {
/// Returns the file metadata as [`Any`] so that it can be downcasted to a
specific
/// implementation.
fn as_any(&self) -> &dyn Any;
+
+ /// Returns the size of the metadata in bytes.
+ fn memory_size(&self) -> usize;
}
/// Cache to store file-embedded metadata.
pub trait FileMetadataCache:
CacheAccessor<ObjectMeta, Arc<dyn FileMetadata>, Extra = ObjectMeta>
{
+ // Returns the cache's memory limit in bytes, or `None` for no limit.
Review Comment:
Makes sense, I'll remove the `Option`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
