nuno-faria commented on code in PR #17031:
URL: https://github.com/apache/datafusion/pull/17031#discussion_r2253600445


##########
datafusion/datasource-parquet/src/file_format.rs:
##########
@@ -449,17 +449,14 @@ impl FileFormat for ParquetFormat {
 
         // Use the CachedParquetFileReaderFactory when metadata caching is 
enabled
         if self.options.global.cache_metadata {

Review Comment:
   I think caching by default would be good. The only situation where it 
wouldn't help would be one-time scans of parquet files that do not require the 
page index, but for large files the scan should largely outweigh the page index 
retrieval anyway.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to