alamb commented on code in PR #10: URL: https://github.com/apache/datafusion-testing/pull/10#discussion_r2268098331
########## data/sqlite/index/random/10/slt_good_4.slt: ########## @@ -32779,25 +32779,40 @@ SELECT DISTINCT + 79 * + COUNT ( * ) FROM tab4 WHERE NOT NULL IS NOT NULL ---- 790 -# Datafusion - Datafusion expected results: -query error DataFusion error: Arrow error: Divide by zero error +# Datafusion - Types were automatically converted from: +# Datafusion - [Expected] III[I][I][I][I] +# Datafusion - [Actual ] II[R][T]I[R][T] +query IIRTIRT rowsort label-5420 SELECT * FROM tab0 WHERE NULL >= - 43 - 12 / ( - 19 / col0 ) +---- Review Comment: yes -- this is one of the tests that actually is updated. I have split up the PR so we can more easily review it ########## data/sqlite/index/between/1/slt_good_0.slt: ########## @@ -38471,52 +38471,52 @@ SELECT pk FROM tab4 WHERE ((col0 >= 2 AND col0 <= 6)) OR ((col3 < 7 AND (col1 IN # Datafusion - Datafusion expected results: # Datafusion - Expected - 0 -query error DataFusion error: SQL error: RecursionLimitExceeded Review Comment: I don't know to be honest I agree the idea that update mode doesn't update for new error messages unless they don't actually match sounds great. I don't know what that is not what is happening with this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
