findepi commented on code in PR #10:
URL: https://github.com/apache/datafusion-testing/pull/10#discussion_r2268786584


##########
data/sqlite/index/between/1/slt_good_0.slt:
##########
@@ -38471,52 +38471,52 @@ SELECT pk FROM tab4 WHERE ((col0 >= 2 AND col0 <= 6)) 
OR ((col3 < 7 AND (col1 IN
 
 # Datafusion - Datafusion expected results:
 # Datafusion - Expected - 0
-query error DataFusion error: SQL error: RecursionLimitExceeded

Review Comment:
   `query error <regex>` uses regex crate, where `match` function searches for 
a substring and there is no API to do a full match. One has to use `^(...)$` in 
the pattern to cater for that.
   
   Given that these tests were passing and are passing, @alamb what about 
dropping the first commit?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to