iffyio commented on code in PR #2009:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2009#discussion_r2290851501
##########
src/parser/mod.rs:
##########
@@ -13438,6 +13439,10 @@ impl<'a> Parser<'a> {
} else if self.parse_keyword_with_tokens(Keyword::XMLTABLE,
&[Token::LParen]) {
self.prev_token();
self.parse_xml_table_factor()
+ } else if self.dialect.supports_semantic_view()
+ && self.parse_keyword_with_tokens(Keyword::SEMANTIC_VIEW,
&[Token::LParen])
+ {
+ self.parse_semantic_view_table_factor()
Review Comment:
Ah so to clarify what I mean is basically that the function
`self.parse_semantic_view_table_factor()` should be able to parse a full table
factor `SEMANTIC_VIEW(...)`. With the current format that isn't the case
because `self.parse_semantic_view_table_factor()` is set up to parse only a
suffix of that table factor, which makes things harder to reuse.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
