bombsimon commented on code in PR #2009:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2009#discussion_r2290903611
##########
src/parser/mod.rs:
##########
@@ -13438,6 +13439,10 @@ impl<'a> Parser<'a> {
} else if self.parse_keyword_with_tokens(Keyword::XMLTABLE,
&[Token::LParen]) {
self.prev_token();
self.parse_xml_table_factor()
+ } else if self.dialect.supports_semantic_view()
+ && self.parse_keyword_with_tokens(Keyword::SEMANTIC_VIEW,
&[Token::LParen])
+ {
+ self.parse_semantic_view_table_factor()
Review Comment:
Alright! I understod what you ment, just not why it was needed since I don't
se a use-case for when it would be re-used. But easy enough to change so
implemented this and now we have `peek_keyword_with_tokens` as well if ever
needed 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]