duongcongtoai commented on PR #17110:
URL: https://github.com/apache/datafusion/pull/17110#issuecomment-3218909560
ok, 1 problem so far
```
for (auto &aggr_exp : aggr.expressions) {
auto &b_aggr_exp =
aggr_exp->Cast<BoundAggregateExpression>();
if (!b_aggr_exp.PropagatesNullValues()) {
join_type = JoinType::LEFT;
}
```
during delim join construction, it should not be always inner join. In some
case depends on the above filter, the delim join condition can be left outer
join. Which is why the last query failed
```
1. query result mismatch:
[SQL] SELECT t1_id, (SELECT max(t2.t2_id) is null FROM t2 WHERE t2.t2_int =
t1.t1_int) x from t1
[Diff] (-expected|+actual)
11 false
- 22 true
+ 22 NULL
33 false
- 44 true
+ 44 NULL
```
I'll add a fix this week
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
