andygrove commented on code in PR #2181:
URL: https://github.com/apache/datafusion-comet/pull/2181#discussion_r2319805359
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -761,8 +763,11 @@ object QueryPlanSerde extends Logging with CometExprShim {
// now supports only Array of primitive
(Seq(CometConf.SCAN_NATIVE_ICEBERG_COMPAT,
CometConf.SCAN_NATIVE_DATAFUSION)
.contains(CometConf.COMET_NATIVE_SCAN_IMPL.get()) && dataType
Review Comment:
`CometConf.COMET_NATIVE_SCAN_IMPL.get()` returns `auto` by default, so this
logic would not get triggered in the default case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
