crepererum commented on PR #17404: URL: https://github.com/apache/datafusion/pull/17404#issuecomment-3253119532
I wonder if this method here is actually dangerous: https://github.com/apache/datafusion/blob/d83a290d1d534f7db9849b11c39d2b0a289a62e4/datafusion/physical-expr/src/equivalence/class.rs#L195-L199 It's clearly broken when 1 constant is shared by two columns. As far as I can tell, this is only used in 2 other places: https://github.com/apache/datafusion/blob/d83a290d1d534f7db9849b11c39d2b0a289a62e4/datafusion/physical-expr/src/equivalence/class.rs#L509-L523 https://github.com/apache/datafusion/blob/d83a290d1d534f7db9849b11c39d2b0a289a62e4/datafusion/physical-expr/src/equivalence/properties/mod.rs#L1291-L1295 So I'm wondering if these two methods have similar bugs :thinking: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
