alamb commented on PR #17404: URL: https://github.com/apache/datafusion/pull/17404#issuecomment-3254000453
> I wonder if this method here is actually dangerous: > > https://github.com/apache/datafusion/blob/d83a290d1d534f7db9849b11c39d2b0a289a62e4/datafusion/physical-expr/src/equivalence/class.rs#L195-L199 > > It's clearly broken when 1 constant is shared by two columns. I don't fully understand this comment. The code in question seems to do what the comments say (return the "canonical expr" so if the `exprs` are `(a, b)` with constants `1,2` it returns `a` as expected It seems like the bug fix in this PR is that the intention was to provide `ConstExprs` for all equivalent expressions, but the code only returned an equivalent expr for the first one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
