kosiew commented on code in PR #17418: URL: https://github.com/apache/datafusion/pull/17418#discussion_r2329417002
########## datafusion/sqllogictest/test_files/select.slt: ########## @@ -620,6 +620,12 @@ select * from (values (1)) LIMIT 10*100; ---- 1 +# select both nulls with basic arithmetic(modulo) +query I +select null % null; +---- +NULL + Review Comment: Consider moving this to operator.slt where arithmetic operator tests are now. Would this also fix other operators besides `%`? Consider adding coverage for other NULL arithmetic cases in operator.slt. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
