destrex271 commented on code in PR #17439:
URL: https://github.com/apache/datafusion/pull/17439#discussion_r2335308027
##########
datafusion/datasource/src/file_scan_config.rs:
##########
@@ -383,7 +383,7 @@ impl FileScanConfigBuilder {
/// Set the output ordering of the files
pub fn with_output_ordering(mut self, output_ordering: Vec<LexOrdering>)
-> Self {
Review Comment:
Should we also modify the type of projected_output_orderings here?
https://github.com/apache/datafusion/blob/da3d90ab1ba8245bfd9151aa312b178b1ca311d0/datafusion/physical-plan/src/streaming.rs#L67
This is a result of modifying the return type of the following functions to
`Result<Vec<Option<LexOrdering>>`
1.
https://github.com/apache/datafusion/blob/da3d90ab1ba8245bfd9151aa312b178b1ca311d0/datafusion/physical-expr/src/physical_expr.rs#L131
2.
https://github.com/apache/datafusion/blob/da3d90ab1ba8245bfd9151aa312b178b1ca311d0/datafusion/core/src/datasource/listing/table.rs#L1132
This is required since in
https://github.com/apache/datafusion/blob/da3d90ab1ba8245bfd9151aa312b178b1ca311d0/datafusion/core/src/datasource/listing/table.rs#L1205
we are creating the output orderings using the `try_create_output_ordering`
function.
There are two solutions:
1. Either modify the return types of `create_output_ordering` and other
functions that are affected by it
2. Preserve the current return type as `Vec<LexOrdering>` and just wrap each
item in the vec into Some() before sending as args to with_output_ordering.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
