destrex271 commented on code in PR #17439:
URL: https://github.com/apache/datafusion/pull/17439#discussion_r2345062474
##########
datafusion/datasource/src/file_scan_config.rs:
##########
@@ -383,7 +383,7 @@ impl FileScanConfigBuilder {
/// Set the output ordering of the files
pub fn with_output_ordering(mut self, output_ordering: Vec<LexOrdering>)
-> Self {
Review Comment:
@crepererum
I guess we should skip modifying the type of expr to Option<LexOrdering>
since at this stage having None seems to be a little useless.
```rust
#[derive(Debug, Clone)]
pub struct SortExec {
/// Input schema
pub(crate) input: Arc<dyn ExecutionPlan>,
/// Sort expressions
expr: LexOrdering,
/// Containing all metrics set created during sort
metrics_set: ExecutionPlanMetricsSet,
/// Preserve partitions of input plan. If false, the input partitions
/// will be sorted and merged into a single output partition.
preserve_partitioning: bool,
/// Fetch highest/lowest n results
fetch: Option<usize>,
/// Normalized common sort prefix between the input and the sort
expressions (only used with fetch)
common_sort_prefix: Vec<PhysicalSortExpr>,
/// Cache holding plan properties like equivalences, output partitioning
etc.
cache: PlanProperties,
/// Filter matching the state of the sort for dynamic filter pushdown.
/// If `fetch` is `Some`, this will also be set and a TopK operator may
be used.
/// If `fetch` is `None`, this will be `None`.
filter: Option<Arc<RwLock<TopKDynamicFilters>>>,
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
