wForget commented on PR #2316: URL: https://github.com/apache/datafusion-comet/pull/2316#issuecomment-3272976251
> Since all we do is call `.toString` on `CometGetDateField` to create a `Literal`, is there a reason to define the enum using `Value` and not string literals? My original intention was to make Value element correspond to spark expression name, and the Value name correspond to part of datafusion datapart function. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
