wForget commented on code in PR #2316:
URL: https://github.com/apache/datafusion-comet/pull/2316#discussion_r2345737849
##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -1681,14 +1681,17 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
- test("Year") {
+ test("DatePart functions:
Year/Month/DayOfMonth/DayOfWeek/DayOfYear/WeekOfYear/Quarter") {
Seq(false, true).foreach { dictionary =>
withSQLConf("parquet.enable.dictionary" -> dictionary.toString) {
val table = "test"
withTable(table) {
sql(s"create table $table(col timestamp) using parquet")
sql(s"insert into $table values (now()), (null)")
- checkSparkAnswerAndOperator(s"SELECT year(col) FROM $table")
+ // TODO: weekday(col)
https://github.com/apache/datafusion-comet/issues/2330
+ checkSparkAnswerAndOperator(
Review Comment:
> Can we change the session timezone when we read the values back?
The input of these methods is `DateType` and output is `IntegerType`, , so
it doesn’t seem to be related to the timezone.
> Also, maybe add some test values corresponding to days before the Unix
Epoch.
Thanks, I will try it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
