jonathanc-n commented on code in PR #17580:
URL: https://github.com/apache/datafusion/pull/17580#discussion_r2350461808
##########
datafusion/sql/src/parser.rs:
##########
@@ -724,13 +728,29 @@ impl<'a> DFParser<'a> {
/// Parse a SQL `CREATE` statement handling `CREATE EXTERNAL TABLE`
pub fn parse_create(&mut self) -> Result<Statement, DataFusionError> {
- if self.parser.parse_keyword(Keyword::EXTERNAL) {
- self.parse_create_external_table(false)
- } else if self.parser.parse_keyword(Keyword::UNBOUNDED) {
- self.parser.expect_keyword(Keyword::EXTERNAL)?;
- self.parse_create_external_table(true)
+ // TODO: Change sql parser to take in `or_replace: bool` inside
parse_create()
+ if self
Review Comment:
@alamb This can be much easier if we can just parse `OR REPLACE` up front
and pass `or_replace` into `parse_create()` at the bottom of this function,
however it might be a breaking change for sqlparser. wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
