iffyio commented on code in PR #2033:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2033#discussion_r2355435475
##########
src/parser/mod.rs:
##########
@@ -8144,6 +8144,11 @@ impl<'a> Parser<'a> {
Keyword::REPLACE,
])?,
)))
+ } else if dialect_of!(self is MySqlDialect | GenericDialect)
+ && self.parse_keyword(Keyword::INVISIBLE)
Review Comment:
```suggestion
} else if self.parse_keyword(Keyword::INVISIBLE)
```
would it make sense to let the parser accept this syntax if it shows up
regardless of dialect? we're trying to move away from the `dialect_of` macro
and if the parser can be more permissive in this case I think it would be ideal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
