altmannmarcelo commented on code in PR #2033:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2033#discussion_r2355450242
##########
src/parser/mod.rs:
##########
@@ -8144,6 +8144,11 @@ impl<'a> Parser<'a> {
Keyword::REPLACE,
])?,
)))
+ } else if dialect_of!(self is MySqlDialect | GenericDialect)
+ && self.parse_keyword(Keyword::INVISIBLE)
Review Comment:
The only downside I see is that if you try this syntax on (let's say)
PostgreSQL it will fail, but if you try it on sqlparser acting as the PG parser
it will accept the invalid syntax. If that is ok I can remove the dialect check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
