LucaCappelletti94 commented on code in PR #2037:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2037#discussion_r2362193656
##########
src/ast/ddl.rs:
##########
@@ -3243,14 +3259,16 @@ pub struct CreateTrigger {
/// ```
pub period: TriggerPeriod,
/// Whether the trigger period was specified before the target table name.
+ /// This does not refer to whether the period is BEFORE, AFTER, or INSTEAD
OF,
+ /// but rather the position of the period clause in relation to the table
name.
///
/// ```sql
- /// -- period_before_table == true: Postgres, MySQL, and standard SQL
+ /// -- period_specified_before_table == true: Postgres, MySQL, and
standard SQL
/// CREATE TRIGGER t BEFORE INSERT ON table_name ...;
- /// -- period_before_table == false: MSSQL
+ /// -- period_specified_before_table == false: MSSQL
/// CREATE TRIGGER t ON table_name BEFORE INSERT ...;
/// ```
- pub period_before_table: bool,
+ pub period_specified_before_table: bool,
Review Comment:
I was finding myself mistaking the meaning of the attribute for: "This
boolean specified whether the TRIGGER is triggered BEFORE the insertion of the
TABLE" instead of the more simple "the period when this trigger is activated is
specified before the TABLE in the SQL", hence the name change to improve
clarity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
