Jefffrey commented on code in PR #17694:
URL: https://github.com/apache/datafusion/pull/17694#discussion_r2366236374


##########
.github/workflows/rust.yml:
##########
@@ -308,17 +308,20 @@ jobs:
     name: cargo test datafusion-cli (amd64)
     needs: linux-build-lib
     runs-on: ubuntu-latest
-    # should be uncommented once 
https://github.com/apache/datafusion/pull/16644 is merged
-    # and cache should be added
-    # container:
-    #  image: amd64/rust
+    container:
+     image: amd64/rust

Review Comment:
   @blaginin before I go too deep debugging this, is this something we still 
want to do? Looks like theres some funkiness as we need to provide host path 
whereas in the code we'll only see the path within the container. I hacked it 
for now with a hardcode to progress the error, see: 
https://github.com/apache/datafusion/pull/17694/commits/930650ea6bd74270f499bb183f15a93596a229c1
   
   But now having another issue. So wanna double check is it worth the effort 
debugging or should we just stick with a runner and not use container here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to