Jefffrey commented on code in PR #17694:
URL: https://github.com/apache/datafusion/pull/17694#discussion_r2380687230
##########
.github/actions/setup-rust-runtime/action.yaml:
##########
@@ -32,11 +30,9 @@ runs:
#
# Set debuginfo=line-tables-only as debuginfo=0 causes immensely slow
build
# See for more details: https://github.com/rust-lang/rust/issues/119560
- #
- # readd the following to the run below once sccache-cache is re-enabled
- # echo "RUSTC_WRAPPER=sccache" >> $GITHUB_ENV
- # echo "SCCACHE_GHA_ENABLED=true" >> $GITHUB_ENV
run: |
echo "RUST_BACKTRACE=1" >> $GITHUB_ENV
+ echo "RUSTC_WRAPPER=sccache" >> $GITHUB_ENV
Review Comment:
Good point actually; I checked against main and didnt see a significant
difference 🤔
I guess `rust-cache` is already sufficient for what we need and sccache is
probably not required in this case; I think I'll remove it here for simplicity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
