2010YOUY01 commented on issue #17789: URL: https://github.com/apache/datafusion/issues/17789#issuecomment-3351111901
I did a PR https://github.com/apache/datafusion/pull/17837 to add a specialized accumulator for no `DISTINCT/ORDER` case. I think it's also necessary in addition to the `GroupsAccumulator`-based solution because - Single group (no group-by) case like `select string_agg(str, ',') from t1` is still using the Accumulator interface instead of GroupsAccumulator - It's very simple to implement, and can be used to compare the performance with the future `GroupsAccumulator` solution The remaining work to close this issue is - Figure out the inefficiency inside `array_agg`, and make the general case (with `DISTINCT/ORDER`) faster - Further speed up with `GroupsAccumulator` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
